fix: reject non-string rules:if - #1909
Merged
Merged
Conversation
A rules entry with an empty if key parses as null and hit string methods directly, so a config mistake surfaced as a TypeError.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rules entry with an empty
if:key parses asnulland reached string methods directly, so a config mistake surfaced asTypeError: null is not an objectinstead of a config error. Fixes #1841.Summary by cubic
Reject non-string values in
rules:ifand show a clear config error instead of a TypeError (fixes #1841). Adds a type check inUtils.evaluateRuleIfand tests fornull, number, boolean, and array inputs.Written for commit 71f1282. Summary will update on new commits.